-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Comparing changes
Open a pull request
base repository: rust-lang/rust-clippy
base: 70b93aab6ec576c3665f38fd485bb5e0154a88f7
head repository: rust-lang/rust-clippy
compare: e170c849420b9da1799b447828c6e6484f16696c
- 12 commits
- 106 files changed
- 5 contributors
Commits on Mar 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 53880a5 - Browse repository at this point
Copy the full SHA 53880a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d055b7d - Browse repository at this point
Copy the full SHA d055b7dView commit details -
Auto merge of #5381 - lzutao:itertools, r=matthiaskrgr
Bump itertools changelog: none
Configuration menu - View commit details
-
Copy full SHA for ec5e9c7 - Browse repository at this point
Copy the full SHA ec5e9c7View commit details -
git attribute macros not allowed in submodules
This change simply moves the `rust` macro definition directly into the attributes for `*.rs` files. git commands that recurse from the rust toplevel tree into submodules produce errors in clippy due to the fact that: "Custom macro attributes can be defined only in top-level gitattributes files" For example, from the toplevel `rust` directory in a rustc development build, try: $ git grep "search string" --recurse-submodules Embedded within the actual results is the error message: [attr]rust text eol=lf whitespace=tab-in-indent,trailing-space,tabwidth=4 not allowed: src/tools/clippy/.gitattributes:1
Configuration menu - View commit details
-
Copy full SHA for b4736b4 - Browse repository at this point
Copy the full SHA b4736b4View commit details -
readme: move "how to run single lint" instructions to "Allowing/denyi…
…ng lints" section.
Configuration menu - View commit details
-
Copy full SHA for 8fbf02c - Browse repository at this point
Copy the full SHA 8fbf02cView commit details -
Auto merge of #5384 - matthiaskrgr:readme_4, r=matthiaskrgr
readme: move "how to run single lint" instructions to "Allowing/denying lints" section. changelog: none
Configuration menu - View commit details
-
Copy full SHA for 6527c3d - Browse repository at this point
Copy the full SHA 6527c3dView commit details -
Auto merge of #5382 - richkadel:gitattributes-macro, r=phansch
git attribute macros not allowed in submodules This change simply moves the `rust` macro definition directly into the attributes for `*.rs` files. git commands that recurse from the rust toplevel tree into submodules produce errors in clippy due to the fact that: "Custom macro attributes can be defined only in top-level gitattributes files" For example, from the toplevel `rust` directory in a rustc development build, try: $ git grep "search string" --recurse-submodules Embedded within the actual results is the error message: [attr]rust text eol=lf whitespace=tab-in-indent,trailing-space,tabwidth=4 not allowed: src/tools/clippy/.gitattributes:1 Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only updates to the latest nightly, you can leave the `changelog` entry as `none`. Otherwise, please write a short comment explaining your change. If your PR fixes an issue, you can add "fixes #issue_number" into this PR description. This way the issue will be automatically closed when your PR is merged. If you added a new lint, here's a checklist for things that will be checked during review or continuous integration. - [ ] Followed [lint naming conventions][lint_naming] - [ ] Added passing UI tests (including committed `.stderr` file) - [ ] `cargo test` passes locally - [ ] Executed `cargo dev update_lints` - [ ] Added lint documentation - [ ] Run `cargo dev fmt` [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints Note that you can skip the above if you are just opening a WIP PR in order to get feedback. Delete this line and everything above before opening your PR. --- changelog: none
Configuration menu - View commit details
-
Copy full SHA for d3c40a1 - Browse repository at this point
Copy the full SHA d3c40a1View commit details
Commits on Mar 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 68ed6cc - Browse repository at this point
Copy the full SHA 68ed6ccView commit details -
Auto merge of #5390 - phansch:rustupp, r=matthiaskrgr
Rustup to rust-lang/rust#70449 cc rust-lang/rust#70449 changelog: none
Configuration menu - View commit details
-
Copy full SHA for 0254c42 - Browse repository at this point
Copy the full SHA 0254c42View commit details -
Auto merge of #5380 - lzutao:deprecate-REPLACE_CONSTS, r=phansch
Deprecate REPLACE_CONSTS lint Closes #5346 changelog: Deprecate `replace_consts` lint
Configuration menu - View commit details
-
Copy full SHA for bfd1123 - Browse repository at this point
Copy the full SHA bfd1123View commit details -
Configuration menu - View commit details
-
Copy full SHA for aff57e0 - Browse repository at this point
Copy the full SHA aff57e0View commit details -
Auto merge of #5392 - matthiaskrgr:rustup_40, r=phansch
rustup rust-lang/rust#70536 changelog: none
Configuration menu - View commit details
-
Copy full SHA for e170c84 - Browse repository at this point
Copy the full SHA e170c84View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 70b93aab6ec576c3665f38fd485bb5e0154a88f7...e170c849420b9da1799b447828c6e6484f16696c