Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust-clippy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 70b93aab6ec576c3665f38fd485bb5e0154a88f7
Choose a base ref
...
head repository: rust-lang/rust-clippy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e170c849420b9da1799b447828c6e6484f16696c
Choose a head ref
  • 12 commits
  • 106 files changed
  • 5 contributors

Commits on Mar 29, 2020

  1. Bump itertools

    tesuji committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    53880a5 View commit details
    Browse the repository at this point in the history
  2. Deprecate REPLACE_CONSTS lint

    tesuji committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    d055b7d View commit details
    Browse the repository at this point in the history
  3. Auto merge of #5381 - lzutao:itertools, r=matthiaskrgr

    Bump itertools
    
    changelog: none
    bors committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    ec5e9c7 View commit details
    Browse the repository at this point in the history
  4. git attribute macros not allowed in submodules

    This change simply moves the `rust` macro definition directly into the
    attributes for `*.rs` files.
    
    git commands that recurse from the rust toplevel tree into submodules
    produce errors in clippy due to the fact that:
    
      "Custom macro attributes can be defined only in top-level
      gitattributes files"
    
    For example, from the toplevel `rust` directory in a rustc development
    build, try:
    
      $ git grep "search string" --recurse-submodules
    
    Embedded within the actual results is the error message:
    
      [attr]rust text eol=lf whitespace=tab-in-indent,trailing-space,tabwidth=4
       not allowed: src/tools/clippy/.gitattributes:1
    richkadel committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    b4736b4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8fbf02c View commit details
    Browse the repository at this point in the history
  6. Auto merge of #5384 - matthiaskrgr:readme_4, r=matthiaskrgr

    readme: move "how to run single lint" instructions to "Allowing/denying lints" section.
    
    changelog: none
    bors committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    6527c3d View commit details
    Browse the repository at this point in the history
  7. Auto merge of #5382 - richkadel:gitattributes-macro, r=phansch

    git attribute macros not allowed in submodules
    
    This change simply moves the `rust` macro definition directly into the
    attributes for `*.rs` files.
    
    git commands that recurse from the rust toplevel tree into submodules
    produce errors in clippy due to the fact that:
    
      "Custom macro attributes can be defined only in top-level
      gitattributes files"
    
    For example, from the toplevel `rust` directory in a rustc development
    build, try:
    
      $ git grep "search string" --recurse-submodules
    
    Embedded within the actual results is the error message:
    
      [attr]rust text eol=lf whitespace=tab-in-indent,trailing-space,tabwidth=4
       not allowed: src/tools/clippy/.gitattributes:1
    
    Thank you for making Clippy better!
    
    We're collecting our changelog from pull request descriptions.
    If your PR only updates to the latest nightly, you can leave the
    `changelog` entry as `none`. Otherwise, please write a short comment
    explaining your change.
    
    If your PR fixes an issue, you can add "fixes #issue_number" into this
    PR description. This way the issue will be automatically closed when
    your PR is merged.
    
    If you added a new lint, here's a checklist for things that will be
    checked during review or continuous integration.
    
    - [ ] Followed [lint naming conventions][lint_naming]
    - [ ] Added passing UI tests (including committed `.stderr` file)
    - [ ] `cargo test` passes locally
    - [ ] Executed `cargo dev update_lints`
    - [ ] Added lint documentation
    - [ ] Run `cargo dev fmt`
    
    [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
    
    Note that you can skip the above if you are just opening a WIP PR in
    order to get feedback.
    
    Delete this line and everything above before opening your PR.
    
    ---
    
    changelog: none
    bors committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    d3c40a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Rustup to rust-lang/rust#70449

    phansch committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    68ed6cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0254c42 View commit details
    Browse the repository at this point in the history
  3. Auto merge of #5380 - lzutao:deprecate-REPLACE_CONSTS, r=phansch

    Deprecate REPLACE_CONSTS lint
    
    Closes #5346
    changelog: Deprecate `replace_consts` lint
    bors committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    bfd1123 View commit details
    Browse the repository at this point in the history
  4. rustup rust-lang/rust#70536

    matthiaskrgr committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    aff57e0 View commit details
    Browse the repository at this point in the history
  5. Auto merge of #5392 - matthiaskrgr:rustup_40, r=phansch

    rustup  rust-lang/rust#70536
    
    changelog: none
    bors committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    e170c84 View commit details
    Browse the repository at this point in the history
Loading