Review add weird test case

rust-lang · Sep 3, 2024 · 8d6272b · 8d6272b
1 parent 1cb9ec8
commit 8d6272b
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/clippy_lints/src/anon_trait_import.rs b/clippy_lints/src/anon_trait_import.rs
@@ -70,7 +70,7 @@ impl<'tcx> LateLintPass<'tcx> for AnonTraitImport {
             // Only check traits
             && let Some(Res::Def(DefKind::Trait, _)) = path.res.first()
             && cx.tcx.maybe_unused_trait_imports(()).contains(&item.owner_id.def_id)
-            // Only check this use if it is only visible to its module (no pub, pub(crate), ...)
+            // Only check this import if it is visible to its module only (no pub, pub(crate), ...)
             && let module = cx.tcx.parent_module_from_def_id(item.owner_id.def_id)
             && cx.tcx.visibility(item.owner_id.def_id) == Visibility::Restricted(module.to_def_id())
             && let Some(last_segment) = path.segments.last()

diff --git a/tests/ui/anon_trait_import.fixed b/tests/ui/anon_trait_import.fixed
@@ -238,3 +238,9 @@ proc_macros::with_span!(
         "foo".type_id();
     }
 );
+
+// Limitation: Suggests `use std::any::Any as _::{self};` which looks weird
+// fn use_trait_self_good() {
+//     use std::any::Any::{self};
+//     "foo".type_id();
+// }
diff --git a/tests/ui/anon_trait_import.rs b/tests/ui/anon_trait_import.rs
@@ -238,3 +238,9 @@ proc_macros::with_span!(
         "foo".type_id();
     }
 );
+
+// Limitation: Suggests `use std::any::Any as _::{self};` which looks weird
+// fn use_trait_self_good() {
+//     use std::any::Any::{self};
+//     "foo".type_id();
+// }