Fixing links #989
Fixing links #989
Conversation
| @@ -9,7 +9,7 @@ Upon finding an `Err`, there are two valid actions to take: | |||
| 1. `panic!` which we already decided to try to avoid if possible | |||
| 2. `return` because an `Err` means it cannot be handled | |||
|
|
|||
| `?` is *almost*[^1] exactly equivalent to an `unwrap` which `return`s | |||
| `?` is *almost*[^†] exactly equivalent to an `unwrap` which `return`s | |||
There was a problem hiding this comment.
So... this one is funky. There are two pages in RBE that are attempting to use the [^1] annotation. The way pulldown-cmark does annotations is by creating a div with id equal to the annotation name (in this case, "1"). This is all well and good, until the print.html page is created, in which case this now results in two different divs with id="1", which is invalid and is a failure to the linkchecker.
I've replaced 1 here with the dagger symbol †, which looks like 1 in the fonts used by RBE, but I am not really sure how to address this issue in general since we basically can't use the 1, 2, 3 footnote style for as long as we intend to have a page that concatenates everything together.
|
LGTM, @QuietMisdreavus u can review and merge this? |
It sounds like this isn't a RBE-specific issue, so we may be able to help out upstream. I've created an issue for it (rust-lang/mdBook#542). |
Fixing links for rust-lang/rust#46194.