Skip to content

Conversation

@spastorino
Copy link
Member

No description provided.

@rust-highfive
Copy link

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@wycats
Copy link

wycats commented Jun 14, 2015

More notably, what's the value of using a tuple (with the confusing (T,) syntax) at this stage?

@spastorino
Copy link
Member Author

Have been talking with @wycats and yes agree with what he says, the thing is that all that adds just noise in this example so the commit message and pr title is not the best.

@mdinger
Copy link
Contributor

mdinger commented Jun 14, 2015

Not much. rbe has historically distinguished between structs with like S { a: b, c: d} and tuplestructs likeT(a, b) and so T(a,) might be useful for showing it uses the tuple syntax. Those 2 sections probably used to be much closer together also.

I have no preference. I typically call everything structures with varying format showing a distinction. Some people may like the distinction in names: for example: edd7059 was moving towards tuple structs. This suggests moving away.

I do think one way should be chosen and it should be followed if possible.

steveklabnik added a commit that referenced this pull request Jun 14, 2015
GenTup is not a tuple so name it as GenVal
@steveklabnik steveklabnik merged commit ae5cc0a into rust-lang:master Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants