Skip to content

Conversation

@sourcefrog
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits: stdin should be in backticks, and there should be an extra // between your first and second line.

@steveklabnik
Copy link
Contributor

This looks great, just a few small nits

@sourcefrog
Copy link
Contributor Author

Thanks, please take another look.

@steveklabnik
Copy link
Contributor

@bors: r+

@steveklabnik
Copy link
Contributor

@bors: rollup

@steveklabnik
Copy link
Contributor

Thank you! :)

steveklabnik added a commit that referenced this pull request Jun 17, 2015
std_misc/process/pipe: Update comments to match current API.
@steveklabnik steveklabnik merged commit a1abae9 into rust-lang:master Jun 17, 2015
@steveklabnik
Copy link
Contributor

Hehe whoops, forgot we don't use Bors here! Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants