Skip to content

Example improvements #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/error/multiple_error_types/wrap_error.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ An alternative to boxing errors is to wrap them in your own error type.

```rust,editable
use std::error;
use std::error::Error as _;
Copy link
Contributor Author

@Rqnsom Rqnsom Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reading the book, this part confused me, and without it worked just fine.

use std::error::Error;
use std::num::ParseIntError;
use std::fmt;

Expand Down
15 changes: 11 additions & 4 deletions src/std/arc.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
# Arc

When shared ownership between threads is needed, `Arc`(Atomic Reference Counted) can be used. This struct, via the `Clone` implementation can create a reference pointer for the location of a value in the memory heap while increasing the reference counter. As it shares ownership between threads, when the last reference pointer to a value is out of scope, the variable is dropped.
When shared ownership between threads is needed, `Arc`(Atomically Reference
Counted) can be used. This struct, via the `Clone` implementation can create
a reference pointer for the location of a value in the memory heap while
increasing the reference counter. As it shares ownership between threads, when
the last reference pointer to a value is out of scope, the variable is dropped.

```rust,editable
use std::time::Duration;
use std::sync::Arc;
use std::thread;

Expand All @@ -11,8 +16,8 @@ fn main() {
let apple = Arc::new("the same apple");

for _ in 0..10 {
// Here there is no value specification as it is a pointer to a reference
// in the memory heap.
// Here there is no value specification as it is a pointer to a
// reference in the memory heap.
let apple = Arc::clone(&apple);

thread::spawn(move || {
Expand All @@ -21,6 +26,8 @@ fn main() {
println!("{:?}", apple);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes 5 apples are printed, sometimes 3 apples...
Let's rather have deterministic behavior with all 10 apples getting printed on the screen.

Joining threads could be used, but that concept is later introduced in 20.1. Threads, so I prefer simple sleep here.

});
}
}

// Make sure all Arc instances are printed from spawned threads.
thread::sleep(Duration::from_secs(1));
}
```