codegen: Deduplicate derive traits added by add_derives() parse callback #3296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivmaykov
force-pushed
the
issue-3286
branch
4 times, most recently
from
680406f to
52081ca
Compare
ivmaykov
force-pushed
the
issue-3286
branch
3 times, most recently
from
5a2c0f4 to
aa5e696
Compare
|
Is bindgen effectively unmaintained? What can I do to get this PR merged? Is this a controversial change? If so, can I have some feedback? |
|
Bindgen is a free-time project for me, this PR was opened two weeks ago. Please be patient because I unfortunately don't have a lot of free time lately :) |
emilio
requested changes
Oct 10, 2025
| where | ||
| I: Iterator<Item = &'a str>, | ||
| { | ||
| // Use a HashSet to track already seen elements. |
There was a problem hiding this comment.
derive lists are usually pretty small, I don't think the copy + hashset overhead is going to be particularly worth it in this case...
That way the is_empty check on the caller can go. WDYT?
| .derive_partialord(false) | ||
| .derive_ord(false) | ||
| .derive_hash(false) | ||
| .parse_callbacks(Box::new(AddDerivesCallback::new(add_derives))) |
There was a problem hiding this comment.
Might be less code to extend bindgen-integration perhaps? But this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3286