Skip to content

Rustfmt is not run if rustup exists, but nightly toonchain/rustfmt-nightly is not installed #1184

Closed
@Kobata

Description

@Kobata

This code will attempt to run rustup run nightly rustfmt in any situation that rustup is available, without fallback to the non-nightly version in the event it fails, for instance due to there not being an installed nightly toolchain.

It appears to have been introduced by #1042

Obviously, there are some known issues with 'old' versions of rustfmt, so prioritizing nightly when possible isn't that bad an idea, however currently there is no fallback of any sort short of preventing bindgen from finding any rustup binary.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions