fix: Support exclusive_range_pattern #9780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: There are some more unstable range patterns that are not supported yet as well, for instance, |
lnicola
approved these changes
Aug 4, 2021
matklad
reviewed
Aug 4, 2021
| p.bump(range_op); | ||
| atom_pat(p, recovery_set); | ||
| if !p.at(T![=>]) { | ||
| // not a range pat like `302 .. => ()` |
Contributor
There was a problem hiding this comment.
Rather than leaving a comment here, better to split the tests:
if p.at(T![=>]) {
// test half_open_range_pat
// fn f() { let x .. = 1; }
} else {
atom_pat(p, recovery_set);
}
Contributor
Author
There was a problem hiding this comment.
You also found a bug with a test of that form! Fixed. Most likely would be seen in user code as if let 1.. = (...) which was not handled properly and is now.
Contributor
|
✌️ lf- can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
@bors r+ |
Member
|
bors r=matklad |
Member
|
bors seems to have crashed earlier today so its stuck |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Already running a review |
Contributor
lnicola
changed the title
bors bot
added a commit
to rust-analyzer/ungrammar
that referenced
this pull request
Aug 13, 2021
37: Add both variants of half open range patterns to the grammar r=lf- a=lf- This is prompted by rust-lang/rust-analyzer#9779, but it is not actually a prerequisite of making that one happen as this commit doesn't change the generated code on the r-a side. Relevant PR (that does not require this one be merged immediately/a release made): rust-lang/rust-analyzer#9780 Co-authored-by: Jade <software@lfcode.ca>
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Nov 11, 2025
37: Add both variants of half open range patterns to the grammar r=lf- a=lf- This is prompted by rust-lang/rust-analyzer#9779, but it is not actually a prerequisite of making that one happen as this commit doesn't change the generated code on the r-a side. Relevant PR (that does not require this one be merged immediately/a release made): rust-lang/rust-analyzer#9780 Co-authored-by: Jade <software@lfcode.ca>
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Nov 15, 2025
37: Add both variants of half open range patterns to the grammar r=lf- a=lf- This is prompted by rust-lang#9779, but it is not actually a prerequisite of making that one happen as this commit doesn't change the generated code on the r-a side. Relevant PR (that does not require this one be merged immediately/a release made): rust-lang#9780 Co-authored-by: Jade <software@lfcode.ca>
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Nov 15, 2025
37: Add both variants of half open range patterns to the grammar r=lf- a=lf- This is prompted by rust-lang/rust-analyzer#9779, but it is not actually a prerequisite of making that one happen as this commit doesn't change the generated code on the r-a side. Relevant PR (that does not require this one be merged immediately/a release made): rust-lang/rust-analyzer#9780 Co-authored-by: Jade <software@lfcode.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9779