feat: Respect #[doc(hidden)] in dot-completion
#9681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
reviewed
Jul 23, 2021
| None => return false, | ||
| }; | ||
| if !vis.is_visible_from(self.db, module.into()) { | ||
| // FIXME: if the definition location is editable, also show private items |
There was a problem hiding this comment.
I think something like
let root_file = defining_crate.root_file(db);
let source_root_id = db.file_source_root(root_file);
!db.source_root(source_root_id).is_librarytells us whether the file is in the workspace or not.
we use that logic for trying to prevent renames in dependencies
There was a problem hiding this comment.
This seems to need some improvements to the test fixture code so it doesn't break tests for item privacy
|
bors r+ |
lnicola
changed the title
#[doc(hidden)] in dot-completion#[doc(hidden)] in dot-completion
bors bot
added a commit
that referenced
this pull request
Jul 28, 2021
9715: feat: Make most completions respect `#[doc(hidden)]` r=jonas-schievink a=jonas-schievink Closes #2003 This continues #9681 and makes most other completion sources respect `#[doc(hidden)]`. After this, only flyimport is missing support for this. bors r+ Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
CompletionContext::is_visibleas a convenience method that checks visibility, presence ofdoc(hidden), and whether the completed item is in the same crate as the completion site or not. We only completedoc(hidden)items from the same crate.This doesn't yet work for all completions:
qualified_pathcompletions useModule::scopeandScopeDef, which doesn't work with this.Part of #7718