Skip to content

Conversation

flodiebold
Copy link
Member

This condition should always be true for valid code, but of course
there might be invalid code or things that we can't currently resolve.

Fixes #8464.

@flodiebold
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Apr 11, 2021
8469: Remove assertion in impl collection r=flodiebold a=flodiebold

This condition should always be true for *valid* code, but of course
there might be invalid code or things that we can't currently resolve.

Fixes #8464.

Co-authored-by: Florian Diebold <flodiebold@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 11, 2021

Build failed:

@flodiebold
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Apr 11, 2021
8469: Remove assertion in impl collection r=flodiebold a=flodiebold

This condition should always be true for *valid* code, but of course
there might be invalid code or things that we can't currently resolve.

Fixes #8464.

Co-authored-by: Florian Diebold <flodiebold@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 11, 2021

Build failed:

This condition should always be true for *valid* code, but of course
there might be invalid code or things that we can't currently resolve.

Fixes rust-lang#8464.
@flodiebold
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 11, 2021

@bors bors bot merged commit 7be0613 into rust-lang:master Apr 11, 2021
@flodiebold flodiebold deleted the fp-assert branch April 11, 2021 10:23
@lnicola
Copy link
Member

lnicola commented Apr 11, 2021

changelog skip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertion failed: fp.is_some() on rustc codebase
2 participants