Skip to content

Pr 556 #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jan 26, 2019
Merged

Pr 556 #665

merged 24 commits into from
Jan 26, 2019

Conversation

matklad
Copy link
Member

@matklad matklad commented Jan 26, 2019

Rebased #556

Thanks @vemoo, now I can change branches without reopening VS Code!

vemoo added 24 commits January 26, 2019 11:46
@vemoo @matklad
initial Watcher impl
1d5eaef
@vemoo @matklad
complete test
d032a1a
@vemoo @matklad
refator to move all io to io module
6b86f03 
use same channel for scanner and watcher
some implementations pending
@vemoo @matklad
handle watched events filtering in Vfsadd is_overlayedload change…
76bf749 
…d files contents in `io`
@vemoo @matklad
reference notify issue
5f31d49
@vemoo @matklad
use notify with fix
b0f7e72
@vemoo @matklad
better error handling
abd8cce
@vemoo @matklad
add missing Task::HandleChange
e69b620
@vemoo @matklad
handle recursive watching ourselves
f181e36
@vemoo @matklad
actually drop watcher, use parking_lot::Mutex
fb1d748
@vemoo @matklad
ignore check event dir for ignore, cleanup tests
eacf7ae
@vemoo @matklad
refactor, put watcher with io::Worker
f88355c 
use `RootFilter` to filter recursive watches
untested
@vemoo @matklad
do not emit create for directory again
7f7c4e7
@vemoo @matklad
move watcher to io module
277e0f1
@vemoo @matklad
avoid boxing
2a1afad
@vemoo @matklad
fix recursive watch
eeed6cf
@vemoo @matklad
simplify and optimize RootFilterby determining if is contained first
10a24cf
@vemoo @matklad
hardcode ".git" and "node_modules" also
0a08650
@vemoo @matklad
better test, avoid duplicated events
be14ab2
@vemoo @matklad
use released notifiy version, add TODO comment
34a34f9
@vemoo @matklad
review fixes
cfbf47b
@vemoo @matklad
extract Roots struct
86fadbd
@vemoo @matklad
use Roots in watcher
d63e1ce
@vemoo @matklad
use entry file_type, improve test
410a3ae
@matklad
Copy link
Member Author

matklad commented Jan 26, 2019

bors r+

bors bot added a commit that referenced this pull request Jan 26, 2019
@bors @vemoo
Merge #665
c869ee2 
665: Pr 556 r=matklad a=matklad

Rebased #556 

Thanks @vemoo, now I can change branches without reopening VS Code!

Co-authored-by: Bernardo <berublan@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 26, 2019

Build succeeded

@bors bors bot merged commit 410a3ae into master Jan 26, 2019
@bors bors bot deleted the pr-556 branch January 26, 2019 08:55
@matklad matklad mentioned this pull request Jan 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matklad @vemoo