Improve assist qualified to top when on first segment #21042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Example
---
```rust
mod std { pub mod fmt { pub trait Debug {} } }
fn main() {
$0std::fmt::Debug;
let x: std::fmt::Debug = std::fmt::Debug;
}
```
**Before this PR**
```rust
use std::fmt;
mod std { pub mod fmt { pub trait Debug {} } }
fn main() {
fmt::Debug;
let x: fmt::Debug = fmt::Debug;
}
```
**After this PR**
```rust
use std::fmt::Debug;
mod std { pub mod fmt { pub trait Debug {} } }
fn main() {
Debug;
let x: Debug = Debug;
}
```
A4-Tacks
force-pushed
the
qualified-top
branch
from
6044bb4 to
af72fd3
Compare
41 tasks
| } | ||
| ", | ||
| r" | ||
| use std::option::Option::Some; |
Member
There was a problem hiding this comment.
I think in most cases people might want importing std::option::Option over this 🤔 (Though triggering the assist with the cursor placed on Option would do the thing but many wouldn't bother it and instead feel that the assist is buggy)
Member
Author
There was a problem hiding this comment.
The PR retained the old behavior on this test and did not change it
ShoyuVanilla
approved these changes
Nov 21, 2025
Member
ShoyuVanilla
left a comment
ShoyuVanilla
left a comment
There was a problem hiding this comment.
It feels a bit exceptional on the first segment, but it's more reasonable than the current behavior and no-op(which would be the most consistent way) so I think this is a reasonable improvement
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #18049
Example
Before this PR
After this PR