fix: Don't trigger two flychecks when saving files that are part of targets #20635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
iorizu
force-pushed
the
fix-double-flycheck
branch
2 times, most recently
from
e09fef6 to
d23bb31
Compare
iorizu
changed the title
iorizu
force-pushed
the
fix-double-flycheck
branch
2 times, most recently
from
7a7220e to
ccc9c25
Compare
iorizu
force-pushed
the
fix-double-flycheck
branch
from
ccc9c25 to
8497cba
Compare
|
Thanks for working on this! Unfortunately, I had no time to review this for days dealing with other issues on next-solver migration. |
|
Take your time! This is a minor issue, after all. |
ShoyuVanilla
approved these changes
Sep 14, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user pressed save in a source file that was part of a specific target, rust-analyzer would trigger two flychecks on the workspace that the file was a part of:
cargo check -p <package> (--bin | --example | --test | --benchmark) <target>)cargo check --workspace)The triggering of the second flycheck cancelled the first, so there was no correctness issue, but the behavior undesirable regardless.
This PR fixes this by making sure that the workspace level check is not triggered if a package check was already triggered.
Closes #20436