Skip to content

Migrate replace_is_method_with_if_let_method Assist to use SyntaxFactory #20134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2025
Merged

Migrate replace_is_method_with_if_let_method Assist to use SyntaxFactory #20134

merged 2 commits into from
Jul 1, 2025

Conversation

Hmikihiro
Copy link
Contributor

part of #15710 and #18285

@Hmikihiro
Migrate replace_is_method_with_if_let_method Assist to use `SyntaxF…
f6a247d 
…actory`

Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2025
@lnicola
Copy link
Member

lnicola commented Jul 1, 2025

I guess this looks fine, but our MSRV is currently 1.86, so we can't use if-let chains. Not sure if we want to bump it right away.

@Hmikihiro
Copy link
Contributor Author

Hmikihiro commented Jul 1, 2025 •
edited
Loading

I guess this looks fine, but our MSRV is currently 1.86, so we can't use if-let chains. Not sure if we want to bump it right away.

I see.
I’ll remove the if-let chains and refactor the code to be compatible with MSRV 1.86.

@Hmikihiro
remove if-let chains
fcc81a3 
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
@lnicola lnicola added this pull request to the merge queue Jul 1, 2025
Merged via the queue into rust-lang:master with commit ce2c0c9 Jul 1, 2025
15 checks passed
@Hmikihiro Hmikihiro deleted the migrate-replace_is_method_with_if_let_method-to-SyntaxFactory branch July 22, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hmikihiro @lnicola @rustbot