Skip to content

fix: Do not error at impls for unsized types that do not include where Self: Sized items #19963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

fix: Do not error at impls for unsized types that do not include where Self: Sized items #19963

merged 1 commit into from
Jun 10, 2025

Conversation

ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Jun 10, 2025 •
edited by rustbot
Loading

Fixes #19962.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2025
@Veykril Veykril added this pull request to the merge queue Jun 10, 2025
Merged via the queue into rust-lang:master with commit f15267a Jun 10, 2025
14 checks passed
@ChayimFriedman2 ChayimFriedman2 deleted the unsized-impl-items branch June 10, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive "not all trait items implemented" (E0046) for items with Self: Sized for unsized impls
3 participants
@ChayimFriedman2 @Veykril @rustbot