Skip to content

fix(ast): return correct types for make::expr_* methods #19569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 14, 2025
Merged

fix(ast): return correct types for make::expr_* methods #19569

merged 4 commits into from
Apr 14, 2025

Conversation

snprajwal
Copy link
Contributor

Much nicer to work with now, less unreachable!()s in the syntax factory.

@snprajwal
fix: make::expr_paren() -> ParenExpr
92a7890 
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
@snprajwal
fix: make::expr_closure() -> ClosureExpr
728d72f 
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
@snprajwal
fix: make::expr_method_call() -> MethodCallExpr
ab620e3 
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
@snprajwal
fix: make::expr_call() -> CallExpr
688464d 
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2025

⚠️ Warning ⚠️

  • There are username mentions (such as @user) in the commit messages of the following commits.
    Please remove the mentions to avoid spamming these users.

@snprajwal snprajwal mentioned this pull request Apr 10, 2025
Closed
Veykril
Veykril approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril added this pull request to the merge queue Apr 14, 2025
Merged via the queue into rust-lang:master with commit dc70a78 Apr 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snprajwal @rustbot @Veykril