Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Show build scripts errors in server status #19294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alibektas
Copy link
Member

Not the prettiest PR so I want to suggest a few things : ( fixes #19184 )

  1. While I was tinkering with our build script runners, I saw that we ignore any Warn level diagnostics but if there are any errors, warnings would also be included in the "problems". Since the PR simply adds showing what cargo check outputs as a server status message, users will now also see these warning when there are errors and not see them where there are not. This tells me that we can add a DiagnosticLevel guard to filter warnings out.
  2. I could better format error messages, since they are not very pleasant to look at.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2025
@alibektas alibektas changed the title minor: Show when build scripts fail what the errors were minor: Show build scripts errors as server status Mar 5, 2025
@alibektas alibektas changed the title minor: Show build scripts errors as server status minor: Show build scripts errors in server status Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message if build.rs panics
3 participants