Skip to content

Fix AsmOption rule in rust.ungram #18715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Veykril merged 1 commit into from
Dec 18, 2024
Merged

Fix AsmOption rule in rust.ungram #18715

Veykril merged 1 commit into from
Dec 18, 2024

Conversation

@aibaars
Copy link
Contributor

@aibaars aibaars commented Dec 18, 2024 •
edited
Loading

@Veykril I think you forgot to move the * operator when translating options := "options(" option *("," option) [","] ")" to an ungrammar rule.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2024
@aibaars aibaars mentioned this pull request Dec 18, 2024
Merged
Veykril
Veykril approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, thanks :)

@Veykril Veykril added this pull request to the merge queue Dec 18, 2024
Merged via the queue into rust-lang:master with commit 27fac08 Dec 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril approved these changes

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aibaars @Veykril @rustbot