Replace Design label with C-Architecture #18492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
I think this is called C-Architecture these days. |
samestep
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7445 added an item to
docs/dev/README.mddescribing and linking to the "Design" issue label, which I assume existed at the time. Later, #12722 updated that URL to point to the new repo location. However, this bullet point is now confusing for two reasons:The URL https://github.com/rust-lang/rust-analyzer/issues?q=is%3Aopen+is%3Aissue+label%Design is malformed. Clicking it in Firefox produces a blank page. Interestingly, clicking the URL while editing this Markdown file inside VS Code changes it to the different URL https://github.com/rust-lang/rust-analyzer/issues?q=is:open+is:issue+label%25Design which is no longer malformed, but that just corresponds to the search string "is:open is:issue label%Design" which is not very meaningful.
There are currently no issues labeled "Design". The corrected search URL https://github.com/rust-lang/rust-analyzer/issues?q=is:open+is:issue+label:Design causes GitHub to display this warning message:
Therefore, this PR replaces that bullet point with a link to the C-Architecture tag.