-
Notifications
You must be signed in to change notification settings - Fork 1.8k
internal: Fix CI running analysis-stats incorrectly against the standard libraries #18328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors r+ |
@bors r- |
a652165
to
705f9ef
Compare
@bors r+ |
fix: Fix CI running analysis-stats incorrectly against the standard libraries Fixes #18326
💔 Test failed - checks-actions |
It seems that we are not getting |
Yes, we set the test cfg which causes core to be empty hence no lang items |
705f9ef
to
7703f1d
Compare
Ugh, now its stuck in const eval somewhere |
7703f1d
to
6ab96cd
Compare
Okay now it should work |
fix: Fix CI running analysis-stats incorrectly against the standard libraries Fixes #18326
cfg_overrides.global = | ||
CfgDiff::new(vec![CfgAtom::Flag(hir::sym::miri.clone())], vec![]).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should be a default for the cli commands
6ab96cd
to
e5af3ae
Compare
Clippy always has the last word |
☀️ Test successful - checks-actions |
Fixes #18326