Skip to content

Fix link syntax #18323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix link syntax #18323

wants to merge 1 commit into from

Conversation

kevinwuhoo
Copy link

There's a small bug in the Markdown syntax for the below dialog:

Screenshot 2024-10-17 at 14 18 58

Removing the backticks should fix this.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2024
@lnicola
Copy link
Member

lnicola commented Oct 17, 2024

The syntax is fine, it's supposed to be monospace, but the dialog probably doesn't accept Markdown.

@Veykril
Copy link
Member

Veykril commented Oct 18, 2024

Yes the bug is likely on the typescript side not telling vscode its markdown

@Veykril
Copy link
Member

Veykril commented Oct 18, 2024

Yes the issue is here

statusBar.tooltip.appendText(status.message);

This ought to be appendMarkdown

bors added a commit that referenced this pull request Oct 22, 2024
Fix status bar messagen not being marked markdown

Closes #18323
bors added a commit that referenced this pull request Oct 22, 2024
Fix status bar message not being marked markdown

Closes #18323
@bors bors closed this in 4fcd31e Oct 22, 2024
lnicola pushed a commit to lnicola/rust that referenced this pull request Oct 29, 2024
…Veykril

Fix status bar message not being marked markdown

Closes rust-lang/rust-analyzer#18323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants