Skip to content

feat: add toggleLSPLogs command #17438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

jjoeldaniel
Copy link
Contributor

@jjoeldaniel jjoeldaniel commented Jun 17, 2024

Implement client-side command to toggle LSP logs in VSCode.

The command replaces the need to add/remove the "rust-analyzer.trace.server": "verbose" setting each time one wants to display logs. I've also updated the docs/ instances that reference the now outdated manual method.

The command labeled rust-analyzer: Toggle LSP Logs enables the setting project-wide and opens the relevant trace output channel.

Closes #8233

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2024
add `toggleLSPLogs` command
update docs to reflect new command
@jjoeldaniel jjoeldaniel marked this pull request as ready for review June 17, 2024 11:42
@Veykril
Copy link
Member

Veykril commented Jun 19, 2024

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Jun 19, 2024

📌 Commit 2ebcf55 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 19, 2024

⌛ Testing commit 2ebcf55 with merge 87ee18d...

@bors
Copy link
Contributor

bors commented Jun 19, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 87ee18d to master...

@bors bors merged commit 87ee18d into rust-lang:master Jun 19, 2024
11 checks passed
@jjoeldaniel jjoeldaniel deleted the toggle_lsp_logs branch June 28, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add: "show LSP logs" command
4 participants