Skip to content

Revert "fix: set the right postfix snippets competion source range" #17054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

roife
Copy link
Member

@roife roife commented Apr 12, 2024

This reverts commit c5686c8.

Fix #17036. See #17036 (comment)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2024
@roife
Copy link
Member Author

roife commented Apr 12, 2024

Perhaps we can consider adding an assert statement for it. 👀

@Veykril
Copy link
Member

Veykril commented Apr 13, 2024

Would certainly be good to somehow assert this invariant in tests at least.
@bors r+

@bors
Copy link
Contributor

bors commented Apr 13, 2024

📌 Commit 7528460 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 13, 2024

⌛ Testing commit 7528460 with merge 9b19462...

@bors
Copy link
Contributor

bors commented Apr 13, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 9b19462 to master...

@bors bors merged commit 9b19462 into rust-lang:master Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postfix snippets no longer work in vscode
4 participants