internal: Lint debug prints and disallowed types with clippy #16470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This was referenced Feb 1, 2024
lnicola
reviewed
Feb 1, 2024
| #[allow(clippy::large_enum_variant)] | ||
| enum CargoMessage { | ||
| CompilerArtifact(Box<cargo_metadata::Artifact>), | ||
| CompilerArtifact(cargo_metadata::Artifact), |
Veykril
force-pushed
the
clippy-disallow
branch
from
a05674d to
9570522
Compare
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Feb 1, 2024
Lint debug prints and disallowed types with clippy
|
💔 Test failed - checks-actions |
Veykril
force-pushed
the
clippy-disallow
branch
from
9570522 to
ae14328
Compare
Veykril
force-pushed
the
clippy-disallow
branch
from
ae14328 to
9e8a0fa
Compare
lnicola
changed the title
|
@bors r+ |
|
@Veykril did you want to keep this open? |
|
☀️ Test successful - checks-actions |
This was referenced Feb 5, 2024
|
No I just forgot to r+ it after fixing the last failure |
This was referenced May 9, 2024
This was referenced May 30, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.