feat: using doc aliases to search workspace symbols #14849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Here's a GIF of the latest version. I made some changes to how aliases are shown. I tried to follow |
alibektas
changed the title
Veykril
reviewed
May 19, 2023
Veykril
reviewed
May 24, 2023
…rching for workspace symbols
Veykril
reviewed
May 25, 2023
Veykril
reviewed
May 25, 2023
|
Here's a GIF of version 2. |
|
@bors r+ |
Veykril
changed the title
|
☀️ Test successful - checks-actions |
|
Thanks for the GIF, by the way! |
My pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc aliases are now visible among symbols and can be used for searching.
fixes #14557