Expand more single ident macro calls upon item collection

[lowr]

Addresses #14781 (comment)

I believe this (almost) brings the number of unresolved names back to pre-#14781:

r-a version	analysis-stats compiler/rustc (rust-lang/rust@69fef92)
pre-#14781 (b069eb7)	exprs: 2747778, ??ty: 122236 (4%), ?ty: 107826 (3%), !ty: 728
#14781 (a7944a9)	exprs: 2713080, ??ty: 139651 (5%), ?ty: 114444 (4%), !ty: 730
with this fix	exprs: 2747871, ??ty: 122237 (4%), ?ty: 108171 (3%), !ty: 676

(I haven't investigated on the increase in some numbers but hopefully not too much of a problem)

This is only a temporary solution. The core problem is that we haven't fully implemented the textual scope of legacy macros. For example, we have been failing to resolve foo in the following snippet, even before #14781 or after this patch. As noted in a FIXME, we need a way to resolve names in textual scope without eager expansion during item collection.

//- /main.rs crate:main deps:lib
lib::mk_foo!();
const A: i32 = foo!();
             //^^^^^^ unresolved-macro-call

//- /lib.rs crate:lib
#[macro_export]
macro_rules! mk_foo {
    () => {
        macro_rules! foo { () => { 42 } }
    }
}

[Veykril]

Using the term eager might be a bit confusing here as there is a concept of eager vs lazy macros

[lowr]

I've replaced it with "immediately" as used in the comment below.

[Veykril]

I wish we had the resources to run analysis stats on rust-lang/rust on CI tbh though I imagine r-a will take ages on that codebase

[lowr]

Yeah, I've run it a few times for this PR and it took more than an hour in total, such a pain :/ (partly because I'm on a relatively old PC though). I wish we had a rust-timer-like bot dedicated to our needs...

[Veykril]

Oh, a rust-timer-like bot for this would be amazing tbh. Wouldn't hurt to bring that up in t-infra at least I guess
btw, you have bors permissions as well (not sure if you were aware of that when we gave the triage team the perms some months ago so just bringing that up)
@bors r+

[bors]

📌 Commit e9ddb62 has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit e9ddb62 with merge daa03b0...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing daa03b0 to master...