feat: add #[doc(alias(..))]-based field and function completions
#14513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
The flyimport fuzzy-search would also need to search for the aliases, but after trying for an hour or more I didn't really get that working. There were some more ways I could've tried, but they would've involved many callsites again. The alias is at least rendered when you type the real name. |
* removes one method breaking the flow
hecatia-elegua
force-pushed
the
alias-based-completion2
branch
from
127560a to
33ee157
Compare
hecatia-elegua
changed the title
|
☔ The latest upstream changes (presumably #14549) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This is done btw, @Veykril if you got some time |
Veykril
approved these changes
Apr 24, 2023
|
I wouldn't touch the flyimport stuff for now, it's already fairly complex (and slow) as is. |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
#[doc(alias(..))]-based field and function completions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #14433
We can now complete fields, functions and some use/mods.
Flyimports don't behave, I don't really have the time to understand the structure there either.
While reading the flyimport code, I removed one method only used there, the closure-tree was a bit confusing, I can revert that if you want.