internal: Resolve labels in body lowering #14509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
label-lower-body
branch
from
674d410 to
1395521
Compare
Veykril
force-pushed
the
label-lower-body
branch
from
1395521 to
0e71179
Compare
|
Ideally we'd also resolve the targets of break and continue expressions in here, but that will require changing how we allocate expressions. Right now we allocate an ID for an expression after having lowered it, to resolve the targets we'd need to preallocate IDs though. Alternatively we could do lowering and resolution separately, but that would introduce another IR -> more memory consumption which we really don't have a lot of budget for currently. @HKalbasi this will probably create a bunch of collisions with your PR sorry 😅 @bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14503 (comment)