internal: Reduce the size of HirFileId from 8 to 4 bytes
#13678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
hir-file-encode
branch
from
d5e38ee to
f45d304
Compare
Veykril
force-pushed
the
hir-file-encode
branch
from
f45d304 to
7bf2a25
Compare
|
@bors r+ |
Veykril
changed the title
HirFileId in a u32 with MSB as the tagHirFileId from 8 to 4 bytes
|
☀️ Test successful - checks-actions |
|
Dashboard confirms 10 MB:
Does this mean we have 10 MB / 4 bytes = 2.5M instances? |
|
well, it is used a lot. But it is also used in some enum variants I think so there it might also affect the max size of the enum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves 10mb on
selfanalysis, while this does limit us to 2billion real files and 2 billion macro expansions, I doubt we will ever hit that limit :)HirFileIdis used a lot, so going from 8 bytes to 4 is a decent win.