internal: Migrate ide_assists::utils and ide_assists::handlers to use format arg captures (part 1)
#13379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DropDemBits
force-pushed
the
ide-assists-format-args-capture
branch
from
2da7fe3 to
0f46f27
Compare
|
It might be better to convert them slowly instead of making one PR for all 91 of them, which will probably bit rot. |
DropDemBits
force-pushed
the
ide-assists-format-args-capture
branch
from
9e2e071 to
d439fb2
Compare
DropDemBits
changed the title
ide_assists::utils and ide_assists::handlers to use format arg captureside_assists::utils and ide_assists::handlers to use format arg captures (part 1)
lnicola
reviewed
Oct 11, 2022
| } | ||
|
|
||
| for term in terms { | ||
| let term_range = term.syntax().text_range(); | ||
| let not_term = invert_boolean_expression(term); | ||
| edit.replace(term_range, not_term.syntax().text()); | ||
| edit.replace(term_range, not_term.to_string()); |
There was a problem hiding this comment.
I thought this introduces an extra allocation, but replace takes Into<String> anyway.
lnicola
reviewed
Oct 11, 2022
| // Appends the type suffix back into the new literal if it exists. | ||
| if let Some(suffix) = suffix { | ||
| converted.push_str(suffix); | ||
| } | ||
|
|
||
| let label = format!("Convert {literal} to {converted}"); |
There was a problem hiding this comment.
Nit: might as well push_str to label instead of using format!. But it's not like this is perf-sensitive either.
lnicola
approved these changes
Oct 11, 2022
bors
added a commit
that referenced
this pull request
Oct 17, 2022
…=Veykril Migrate assists to format args captures, part 2 Continuation of #13379 Migrates: - `generate_constant` - `generate_default_from_enum_variant` - `generate_default_from_new` - `generate_delegate_methods` - `generate_deref` - `generate_documentation_template` - `generate_enum_is_method` - `generate_enum_projection_method` - `generate_from_impl_for_enum` - `generate_function` - `generate_getter` - `generate_impl` - `generate_new` - `generate_setter`
Veykril
added
the
S-waiting-on-review
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Nov 5, 2022
…=Veykril Migrate assists to format args captures, part 3 Continuation of #13379 Migrates: - `inline_call` - `inline_local_variable` - `introduce_named_lifetime` - `merge_match_arms` - `move_from_mod_rs` - `move_guard` - `move_module_to_file` - `move_to_mod_rs` - `number_representation` - `qualify_method_call` - `qualify_path` - `raw_string` - `remove_dbg` - `replace_derive_with_manual_impl` - `replace_or_with_or_else` - `replace_turbofish_with_explicit_type` - `unwrap_tuple` - `wrap_return_type_in_result`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This not only serves as making future migration to mutable syntax trees easier, it also finds out what needs to be migrated in the first place.
Aside from the first commit, subsequent commits are structured to only deal with one file/handler at a time.This is the first of 3 PRs, migrating:
Utils:
gen_trait_fn_bodyrender_snippetReferenceConversionconvert_typegetterHandlers:
add_explicit_typeadd_return_typeadd_turbo_fishapply_demorganauto_importconvert_comment_blockconvert_integer_literalconvert_into_to_fromconvert_iter_for_each_to_forconvert_let_else_to_matchconvert_tuple_struct_to_named_structconvert_two_arm_bool_match_to_matches_macrodestructure_tuple_bindingextract_functionextract_moduleextract_struct_from_enum_variantextract_type_aliasextract_variablefix_visibility