Generate rust type from json #12905
Merged
Generate rust type from json #12905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HKalbasi
commented
Jul 28, 2022
| && node.first_token().map(|x| x.kind()) == Some(SyntaxKind::L_CURLY) | ||
| && node.last_token().map(|x| x.kind()) == Some(SyntaxKind::R_CURLY) | ||
| { | ||
| let node_string = node.to_string(); |
There was a problem hiding this comment.
Is there any way to not create a new string here?
There was a problem hiding this comment.
You could fetch the file's backing string and indexing into that with the node's range
Veykril
reviewed
Jul 28, 2022
HKalbasi
force-pushed
the
master
branch
6 times, most recently
from
596fd71 to
e70fb0d
Compare
Veykril
reviewed
Aug 3, 2022
HKalbasi
force-pushed
the
master
branch
2 times, most recently
from
de9706b to
802b3f6
Compare
|
Thanks! |
|
☀️ Test successful - checks-actions |
json-to-type.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10118
Should this be a diagnostic? I made it a diagnostic because of issue label.