Regression(?): proc macro not expanded since v0.3.1091

[andrew-sol]

I use NEAR Rust SDK crate (https://docs.rs/near-sdk/latest/near_sdk).
I see "proc macro not expanded" errors everywhere after the update to v0.3.1091.

v0.3.1083 works fine.

rust-analyzer version: 0.3.1091
rustc version: rustc 1.61.0 (fe5b13d68 2022-05-18)
relevant settings: CARGO, RUSTUP_HOME, RUSTUP_HOME are empty

[bjorn3]

You will need to update rustc. Between the rustc version you are using and the latest one there has been an abi breaking change in the proc_macro implementation. Rust-analyzer 0.3.1091 updated for the new abi and thus broke support for the old abi (on nightly rustc at least) Rust-analyzer doesn't attempt to support nightlies other than the latest.

[lnicola]

There was a change affecting 1.63 nightlies, but it shouldn't have any effect on 1.61.

[bjorn3]

Right, misread the rustc version.

[Veykril]

The latest release upgraded the diagnostic to warning from weak-lint since we now properly detect whether proc-macros are disabled or not. So these errors might not be new for your project, they are just more visible now.

This usually indicates some other build problem for r-a in your project. The easy way out is to disable the specific diagnostic via the settings, though that might give you a worse experience overall for other IDE features still. There might be some information in the server logs as to what is going wrong.

Browsing the near-sdk repo works fine for me, the few uses of some proc-macros expand properly.

[arnolddevos]

Same problem here but with yew macros. Versions as above:

rust-analyzer version: 0.3.1091
rustc version: rustc 1.61.0 (fe5b13d68 2022-05-18)
yew version: "0.19.3"

ra shows an error unresolved-proc-macro for yew's Properties, function_component and html macros. There was no warning or error with the previous ra version and cargo builds the project without warnings or errors.

[andrew-sol]

Will clarify a bit. In my case (NEAR SDK) the error appears only for attribute macroses and derive macroses:

#[near_bindgen]
#[ext_contract(...)]
#[derive(BorshDeserialize, BorshSerialize, PanicOnDefault)]

Some of them are from this crate: https://docs.rs/borsh/latest/borsh.

Log (Extension Host) doesn't show any errors.

EDIT: "Rust Analyzer Language Server" and "Rust Analyzer Language Server Trace" log channels are empty.

[lnicola]

(sneaky little macroses 😅)

The log channel is called Rust Analyzer Language Server.

[sumerman]

Same problem with pgx macroses.

• rustc 1.61.0
• pgx 0.3.1

[lnicola]

@sumerman do you have some public code showing this problem?

[Veykril]

The borsh and yew macros work fine for me on rustc 1.61 with latest r-a.

For anyone having errors here, please check your Rust Analyzer Language Server logs for any warnings or errors and check your configs for anything build related that might impact the build script execution of rust-analyzer, that is any of the rust-analyzer.cargo.* and rust-analyzer.procMacro.* configs. It might help setting your rust-analyzer.server.extraEnv to { "RA_LOG": "warn,rust_analyzer::reload=info" } as well for more useful outputs.

As a reminder, if you get errors now but didn't onl last r-a it is almost certainly because the weak-lint warning got upgraded, so they were erroring for you before they were just barely visible.
Note that there is a small bug here if you have proc-macros disabled alltogether, that is rust-analyzer.procMacro.enable: false, then you'll see a bunch of errors you shouldn't see. #12528 Fixes that. But if you have that setting enabled this release shouldn't be causing any new errors for you, only showing you ones that the previous release didn't really show. This doesn't actually cause non weak-lints.

[Veykril]

And for those that either do not want to investigate why their proc-macro's don't get resolved by r-a, or want to get around this since they want to work before investigating it, you can set "rust-analyzer.diagnostics.disabled": ["unresolved-proc-macro"] which should hide these errors. Note though that all the proc-macros that error aren't being expanded and as such will degrade your overall experience most likely.

[sumerman]

@sumerman do you have some public code showing this problem?

Sure, this repo for instance.

Older ra versions do indeed highlight the same type of issue, but with less visual impact. Although, I'm not sure how am I expected to fix it. "Jump-to-definition" still works for the affected macros. "Expand macro recursively" used to work (and still does), with rust 1.59.0, but breaks on 1.61.0

[lnicola]

After setting up cargo pgx, expanding #[pg_extern] seems to work for me, both in stable and beta: