Wrong error and warning underline positions on Windows

[EFanZh]

rust-analyzer version: ce9b174 2022-05-17 nightly

rustc version: 1.60.0 (7737e0b5c 2022-04-04)

I got wrong warning and error underline positions with CRLF line ending source files on Windows:

If I change file line ending to LF, then the underlines are shown at their correct positions:

[Antelope13]

I am seeing the same thing in VS Code on Windows. Reverting the extension to v0.3.1054 fixes the issue.

[bjorn3]

Maybe caused by #12190?

[griffi-gh]

@bjorn3 Maybe but don't have any non-ascii characters in my code?

[bjorn3]

Rust-analyzer normalizes crlf into lf when loading source files as required by the rust grammar. I suspect #12190 didn't account for this and emitted offsets based on the version of the text with lf line endings rather than the original crlf version.

[griffi-gh]

oh

[mdegans]

Rust-analyzer normalizes crlf into lf when loading source files as required by the rust grammar. I suspect #12190 didn't account for this

This sounds likely. If I change VsCode's line endings to LF in Windows the squigglies appear in the correct places now. For those stumbling across this, just search (f1) for eol , select Change End of Line Sequence then LF.

[RReverser]

Ohh so that's what it is. Glad to hear reverting to previous version helps - before seeing this issue I assumed some local cache was corrupted and tried all possible methods of clean rebuld / restart / etc.

Ohh so that's what it is. Glad to hear reverting to previous version helps - before seeing this issue I assumed some local cache was corrupted and tried all possible methods of clean rebuld / restart / etc.

I was thinking the same, I just lost 30 mins of my life...

I had to revert to version 0.2.1048, this is really breaking my workflow.