Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Conversation

@Eijebong
Copy link
Contributor

I just mirrored the cargo build option within the rls config struct.

For some reasons I have some tests writing to stderr, I can't figure out where this is coming from. I don't know if it's a problem in my tests or not.

@Xanewok
Copy link
Contributor

Xanewok commented Sep 27, 2017

Hi, thanks for the PR!

Regarding the tests and stderr, it's reported (#393) and I wouldn't worry about that.

It'd be good to also include the additional "rust.{...}" configuration for that on the rls-vscode side. Would you mind also filing a PR there with the added configuration options?

@Eijebong
Copy link
Contributor Author

Eijebong commented Sep 29, 2017

Done :)

Edit: Ow, tests have changed, I'll rebase properly tomorrow

@Eijebong Eijebong force-pushed the features branch 2 times, most recently from 5df7eb5 to 94f8e22 Compare September 30, 2017 11:30
@Eijebong
Copy link
Contributor Author

Build failure seems to be unrelated

@Eijebong Eijebong mentioned this pull request Sep 30, 2017
@Xanewok
Copy link
Contributor

Xanewok commented Oct 2, 2017

@Eijebong could you try closing and re-opening to redo the CI build?

@Eijebong Eijebong force-pushed the features branch 2 times, most recently from a9591c6 to 8981f3b Compare October 2, 2017 11:39
@Eijebong
Copy link
Contributor Author

Eijebong commented Oct 2, 2017

@Xanewok Rebased and pushed. It didn't work. Do I have to open another PR for appveyor to throw away its cache ?

@Xanewok
Copy link
Contributor

Xanewok commented Oct 2, 2017

Not sure how AppVeyor cache works exactly, but if it's gonna refresh on another PR, doesn't hurt to try.
In general AppVeyor has some hiccups recently wrt the cache, so that in itself might be worth looking into.

@nrc
Copy link
Member

nrc commented Oct 5, 2017

@Eijebong there is still (or perhaps again?) a merge conflict, so I think this needs another rebase. Lets not worry about Appveyor, as long as Travis is green we can land.

@Xanewok
Copy link
Contributor

Xanewok commented Oct 9, 2017

AppVeyor cache was purged (#510), so ideally it should also be green now, after rebase, too!

I just mirrored the cargo build option within the rls config struct
@Eijebong
Copy link
Contributor Author

Rebased

@Xanewok Xanewok merged commit 96d7461 into rust-lang:master Oct 10, 2017
@Xanewok
Copy link
Contributor

Xanewok commented Oct 10, 2017

🚥 All green now, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants