-
Notifications
You must be signed in to change notification settings - Fork 253
Add support for cargo features #500
Conversation
|
Hi, thanks for the PR! Regarding the tests and stderr, it's reported (#393) and I wouldn't worry about that. It'd be good to also include the additional |
|
Done :) Edit: Ow, tests have changed, I'll rebase properly tomorrow |
5df7eb5 to
94f8e22
Compare
|
Build failure seems to be unrelated |
|
@Eijebong could you try closing and re-opening to redo the CI build? |
a9591c6 to
8981f3b
Compare
|
@Xanewok Rebased and pushed. It didn't work. Do I have to open another PR for appveyor to throw away its cache ? |
|
Not sure how AppVeyor cache works exactly, but if it's gonna refresh on another PR, doesn't hurt to try. |
|
@Eijebong there is still (or perhaps again?) a merge conflict, so I think this needs another rebase. Lets not worry about Appveyor, as long as Travis is green we can land. |
|
AppVeyor cache was purged (#510), so ideally it should also be green now, after rebase, too! |
I just mirrored the cargo build option within the rls config struct
|
Rebased |
|
🚥 All green now, thanks! |
I just mirrored the cargo build option within the rls config struct.
For some reasons I have some tests writing to stderr, I can't figure out where this is coming from. I don't know if it's a problem in my tests or not.