-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Change the Range struct to support inclusive ranges #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
- Feature Name: inclusive_ranges | ||
- Start Date: (fill me in with today's date, YYYY-MM-DD) | ||
- RFC PR: (leave this empty) | ||
- Rust Issue: (leave this empty) | ||
|
||
# Summary | ||
|
||
Change the Range struct to allow all combinations of inclusive/exclusive ranges. | ||
|
||
# Motivation | ||
|
||
Regardless of how the range syntax will eventually work, the underlying data | ||
structure will need to support both inclusive and exclusive ranges. If we don't | ||
do this now, libraries will define their own way of specifying ranges (as the | ||
rand crate and the BTreeMap collection have already done) and these custom | ||
implementations may become entrenched. | ||
|
||
# Detailed design | ||
|
||
The design is simply to: | ||
|
||
1. Remove the `Unbounded` variant of the `Bound<Idx>` enum and move it to the | ||
ops module. | ||
2. Change `Range` (and all variations there of) to use `Bound<Idx>` instead of | ||
`Idx` for start and end. | ||
|
||
```rust | ||
pub enum Bound<Idx> { | ||
Inclusive(Idx), | ||
Exclusive(Idx), | ||
} | ||
pub struct Range<Idx> { | ||
pub start: Bound<Idx>, | ||
pub end: Bound<Idx>, | ||
} | ||
pub struct RangeFrom<Idx> { | ||
pub start: Bound<Idx>, | ||
} | ||
pub struct RangeTo<Idx> { | ||
pub end: Bound<Idx>, | ||
} | ||
pub struct RangeFull; | ||
``` | ||
|
||
# Drawbacks | ||
|
||
* The Range struct becomes larger. | ||
* When checking the bounds, you have to check if they are inclusive/exclusive. | ||
|
||
# Alternatives | ||
|
||
One obvious alternative is the following: | ||
|
||
```rust | ||
pub enum Bound<Idx> { | ||
Inclusive(Idx), | ||
Exclusive(Idx), | ||
Unbounded, | ||
} | ||
pub struct Range<Idx> { | ||
pub start: Bound<Idx>, | ||
pub end: Bound<Idx>, | ||
} | ||
``` | ||
|
||
However, this would make it impossible to do things like only allowing full | ||
ranges (see slicing OsString). | ||
|
||
# Unresolved questions | ||
|
||
We might want some way to extract inclusive bounds from any *integral* range to | ||
make bounds checking easier. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the range syntax of this exclusive bound?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This RFC doesn't address syntax.