Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow #[must_use] on functions, rather than just types. Mark Result::{ok,err} #[must_use]. #886

Closed
wants to merge 9 commits into from
Closed

Allow #[must_use] on functions, rather than just types. Mark Result::{ok,err} #[must_use]. #886

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
763fd5d
Allow `#[must_use]` on functions, rather than just types. Mark
huonw Feb 19, 2015
cfc59a6
Add metadata.
huonw Feb 19, 2015
3b0d1e6
Tweak a paragraph.
huonw Feb 19, 2015
e68a4d5
More drawbacks.
huonw Feb 19, 2015
86245c5
Add detailed analysis of `ok` vs `let _ =`.
huonw Feb 19, 2015
f95ee6c
Typo.
huonw Feb 19, 2015
86e3e77
Point to the appendix.
huonw Feb 19, 2015
96c62fa
Formatting, mention ignored URLs.
huonw Feb 19, 2015
ca877fb
Whoops, an invalid newline snuck in.
huonw Feb 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting, mention ignored URLs.
  • Loading branch information
@huonw
huonw committed Feb 19, 2015
commit 96c62fad39679c9500230d0a8c8fef28b8691f63
17 changes: 12 additions & 5 deletions text/0000-must-use-functions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,18 @@ grepped for `\.ok` and `let _ =`.
Initially just I scrolled around and clicked things, may 10-15, the
rest were running this JS `var list = $("a");
window.open(list[(Math.random() * list.length) | 0].href, '_blank')`
to open literally random links in a new window. The grepping was
performed by running `runit url`, where `runit` is: ```bash function
runit () { cd ~/tmp; git clone $1; cd $(basename $1); git grep '\.ok'
| wc -l; git grep 'let _ =' | wc -l; } ``` If there were any `ok`s, I
manually read the grep to see if they were used on not.
to open literally random links in a new window. Links that were not
projects (including 404s from deleted projects) and duplicates were
ignored. The grepping was performed by running `runit url`, where
`runit` is the shell function:

```bash
function runit () { cd ~/tmp; git clone $1; cd $(basename $1); git grep '\.ok'
| wc -l; git grep 'let _ =' | wc -l; }
```

If there were any `ok`s, I manually read the grep to see if they were
used on not.

## Data

Expand Down