Give pre-RFC suggestions and clarify PR process #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| stamp, and in particular still does not mean the feature will ultimately | ||
| be merged; it does mean that in principle all the major stakeholders | ||
| have agreed to the feature and are amenable to merging it. | ||
| Once an RFC becomes active then authors may implement it and submit |
There was a problem hiding this comment.
While we're updating this, it may be worth clarifying if the author of the RFC is expected to implement the feature or not. Maybe there should at least be some understanding of who's going to implement it and when? There are some accepted RFCs that have just been sitting there without an implementation for a while now.
There was a problem hiding this comment.
I was considering that, but didn't know quite what to write. It's best if the author is capable of and willing to implement the RFC, but it's not a requirement.
There was a problem hiding this comment.
Added some text about this.
|
👍 |
brson
added a commit
that referenced
this pull request
Dec 11, 2014
Give pre-RFC suggestions and clarify PR process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on workweek discussions here are some minor updates to the RFC process.
TL;DR is that we are no longer going to do RFC approvals at the meeting, are going to try to have more ad-hoc meetings involving a wider group of contributors, will insist on summaries of those meetings being delivered back to the PR threads, core team will make final decisions based on discussion in the thread.
We will try to invite community stakeholders to more weekly meetings to discuss their RFCs as needed. I've also added some text about how to properly prepare before submitting an RFC.