Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove implicit features in a new edition #3491

Merged
merged 10 commits into from
Oct 14, 2023
Merged

RFC: Remove implicit features in a new edition #3491

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f46f10b
feat: Create remove-implicit-feature RFC skeleton
epage Sep 18, 2023
8dd6bff
feat: Initial draft
epage Sep 19, 2023
1f7f2b9
fix: Update RFC number
epage Sep 19, 2023
1da77ae
fix: Clarify opening use of 'feature'
epage Sep 19, 2023
9fc4a76
fix: Add warning group alternative
epage Sep 19, 2023
d8a7c03
fix: Typo
epage Oct 3, 2023
fa464d1
fix: Remove bad reference to cfg for optional dep
epage Oct 3, 2023
b1c02ae
fix: Focus existing edition behavior on goal and list contingency
epage Oct 3, 2023
39b7fa1
fix: Typo
epage Oct 3, 2023
1db0bd7
Add tracking issue
ehuss Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Typo 
Co-authored-by: Arlo Siemsen <arkixml@gmail.com>
  • Loading branch information
@epage @arlosi
epage and arlosi authored Oct 3, 2023
commit 39b7fa1126e7f7b43ec69ad917115a1c65bc128f
2 changes: 1 addition & 1 deletion text/3491-remove-implicit-features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Where undesired, users can remove these and switch their references to the
dependency from `foo` to `dep:foo`,
dealing with the [potential breaking changes](https://doc.rust-lang.org/cargo/reference/semver.html#cargo-remove-opt-dep).

Ideally, this will be accomplished by `cargo` emitting an allow-by-defaylt
Ideally, this will be accomplished by `cargo` emitting an allow-by-default
warning when parsing a workspace member's package when an optional dependency
is not referenced via `dep:` in the features
([rust-lang/cargo#9088](https://github.com/rust-lang/cargo/issues/9088))
Expand Down