Fix 404 handling #3411
Merged
Fix 404 handling #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
added
the
not-rfc
|
@Mark-Simulacrum Can you maybe review/merge this? I'm not sure how to get other people to help with reviews in this repo, and not sure who else to ask, and not sure if anyone would be upset if I just merged it myself. |
calebcartwright
approved these changes
May 25, 2023
Mark-Simulacrum
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the 404 not-found handling so that the not-found page can load javascript/css resources. Otherwise pages like https://rust-lang.github.io/rfcs/foo do not render correctly.