Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support defining C-compatible variadic functions in Rust #2137

Merged
merged 25 commits into from
Sep 29, 2017
Merged

Support defining C-compatible variadic functions in Rust #2137

merged 25 commits into from
Sep 29, 2017

Commits on Sep 3, 2017

  1. Support defining C-compatible variadic functions in Rust

    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    019dff4 View commit details
    Browse the repository at this point in the history

  2. Add VaArg for size_t and ssize_t; sort and group the VaArg impls better

    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    3039f17 View commit details
    Browse the repository at this point in the history

  3. Allow calling extern "C" functions that accept a va_list

    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    12eb69f View commit details
    Browse the repository at this point in the history

  4. Drop variadic closures 

    Rust doesn't support passing a closure as an `extern "C" fn`, so these
wouldn't serve any purpose yet.
    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    e6b5cfb View commit details
    Browse the repository at this point in the history

  5. Fix typo in sample code

    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    e9fe291 View commit details
    Browse the repository at this point in the history

  6. Drop impls for libc, mention that type aliases cover this

    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    247991e View commit details
    Browse the repository at this point in the history

  7. Make VaArg an unsafe trait

    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    0cca2ce View commit details
    Browse the repository at this point in the history

  8. Fix typo in sample code

    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    3161c45 View commit details
    Browse the repository at this point in the history

  9. Drop VaList::start; name the VaList argument instead, to improve life… 

    …times

This allows the compiler to pass an appropriate lifetime without as much
magic.
    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    7b7b3ff View commit details
    Browse the repository at this point in the history

  10. Declare args as mut

    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    9d060c4 View commit details
    Browse the repository at this point in the history

  11. Rework the alternatives; the new syntax isn't the "alternative" anymore

    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    3769670 View commit details
    Browse the repository at this point in the history

  12. Fix another reference to VaList::start

    @joshtriplett
    joshtriplett committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    63b5545 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2017

  1. Clarify the description of argument promotion

    @joshtriplett
    joshtriplett committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    5437ab2 View commit details
    Browse the repository at this point in the history

  2. Get rid of the VaArg trait 

    Just specify that the compiler must ensure that VaList::arg gets called
only for types allowed in FFI calls, including `#[repr(C)]` structs and
non-value-carrying enums with a `repr`-specified discriminant type.
    @joshtriplett
    joshtriplett committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    7bd8d7d View commit details
    Browse the repository at this point in the history

  3. Don't impl Drop directly; just talk about the necessary drop semantics

    @joshtriplett
    joshtriplett committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    96f80ac View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2017

  1. Fix extern "C" function declarations

    @joshtriplett
    joshtriplett committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    18a8b36 View commit details
    Browse the repository at this point in the history

  2. Allow VaList::arg to return any type usable in an extern "C" fn s… 

    …ignature
    @joshtriplett
    joshtriplett committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    7e5698e View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2017

  1. Use extern type to declare VaList (see RFC 1861)

    @joshtriplett
    joshtriplett committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    105f764 View commit details
    Browse the repository at this point in the history

  2. Move the mention of language items to the reference-level explanation

    @joshtriplett
    joshtriplett committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    6bdb95c View commit details
    Browse the repository at this point in the history

  3. Use the rustdoc-style /* fields omitted */ syntax to declare VaList 

    `extern type` doesn't quite have the right semantics.
    @joshtriplett
    joshtriplett committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    1546c82 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2017

  1. Require that the function have at least one non-variadic argument

    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    eca3eae View commit details
    Browse the repository at this point in the history

  2. Add some clarifications on drop handling, and non-standard behavior

    @joshtriplett
    joshtriplett committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    e3d1f5c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2017

  1. Stop using Clone; implement copy safely via a closure 

    Huge thanks to Without Boats for help working out the details here.
    @joshtriplett
    joshtriplett committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    b2acc33 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2017

  1. Add an unresolved question on support for non-native ABIs

    @joshtriplett
    joshtriplett committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    4042834 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2017

  1. RFC 2137: Support defining C-compatible variadic functions in Rust

    @aturon
    aturon authored Sep 29, 2017
    Configuration menu
    Copy the full SHA
    eb9c392 View commit details
    Browse the repository at this point in the history