GitHub Workflows security hardening #932
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex <aleksandrosansan@gmail.com>
BurntSushi
approved these changes
Dec 8, 2022
BurntSushi
requested changes
Dec 8, 2022
Member
BurntSushi
left a comment
BurntSushi
left a comment
There was a problem hiding this comment.
Thanks! I would like to request that we add some docs about why we are setting this in the CI yaml itself.
| - cron: '00 01 * * *' | ||
|
|
||
| permissions: | ||
| contents: read # to fetch code (actions/checkout) |
Member
There was a problem hiding this comment.
Could you add a comment explaining why this is here, and also when one might want to change or update it? Please also link to the GitHub docs page from your PR comment.
Contributor
Author
There was a problem hiding this comment.
Please take a look.
Member
|
Thanks! The formatting and commit hygiene still needed some work, so I just went ahead and did that myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from
on: pull_requestfrom external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.