Expand block expression section #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Don't consider semicolons part of the statement. As per the `stmt` macro matcher, they're not a part of it. They are a part of the block expression though, so the grammar is updated to show that. 2. Try to better describe what a block expression is. By saying it's like a module, we're probably confusing people. 3. Show an example of using a block expression to force moving a value out of a variable. I personally didn't understand what that fully entailed until I wrote the example. 4. Link to the unsafety section instead of redescribing what unsafe is allowed to do in the unsafe block section.
matthewjasper
approved these changes
Jul 29, 2018
|
@matthewjasper Is there anything preventing this from being merged? |
Havvy
added
New Content
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't consider semicolons part of the statement. As per the
stmtmacro matcher, they're not a part of it. They are a partof the block expression though, so the grammar is updated to
show that.
Try to better describe what a block expression is. By saying
it's like a module, we're probably confusing people.
Show an example of using a block expression to force moving a
value out of a variable. I personally didn't understand what
that fully entailed until I wrote the example.
Link to the unsafety section instead of redescribing what
unsafe is allowed to do in the unsafe block section.