Skip to content

Change path to the derive macro#2218

Closed
nik-rev wants to merge 1 commit into
rust-lang:masterfrom
nik-contrib:core-derive
Closed

Change path to the derive macro#2218
nik-rev wants to merge 1 commit into
rust-lang:masterfrom
nik-contrib:core-derive

Conversation

@nik-rev

@nik-rev nik-rev commented Mar 31, 2026

Copy link
Copy Markdown

The derive macro will be exported from the crate root once rust-lang/rust#154442 is merged:

std/attr.derive.html:2: broken link - `/checkout/obj/build/reference/attributes/derive.html`
core/attr.derive.html:2: broken link - `/checkout/obj/build/reference/attributes/derive.html`

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Mar 31, 2026
@ehuss

ehuss commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

I don't believe this is the correct change. The reason the link is failing in rust-lang/rust#154442 is because the documentation that would sit at https://doc.rust-lang.org/nightly/std/attr.derive.html has the documentation at macros/mod.rs. That documentation has a link that is ../../../reference because that documentation was written for when it existed in the prelude docs.

I don't immediately know how to fix that since I'm not sure if the docs will now show up in both places (since it is a re-export). I think the answer is to use #[doc(no_inline)] in v1.rs, but it will take some experimenting to see what works.

@ehuss

ehuss commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

And to clarify, it would be to add no_inline and to also adjust the ../../.. part to use just .. (I think).

@nik-rev

nik-rev commented Apr 1, 2026

Copy link
Copy Markdown
Author

Thank you @ehuss , that worked!

@nik-rev nik-rev closed this Apr 1, 2026
@rustbot rustbot removed the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants