Only search src/version in rust-lang/rust, not subtrees
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
force-pushed
the
pa-fix-commit-walking
branch
from
cca5f59
to
f01adc0
Compare
Mark-Simulacrum
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While branching off the beta today, promote-release pushed the wrong merge commit to the beta branch. It turned out that commit was from miri, as part of a subtree pull. This was because the code in promote-release checked any commit authored by bors, so subtree pulls merged by bors in other repositories would also be discovered.
This PR fixes the problem by instead only walking to the first parent of each commit, restricting the search to just the merge commits bors pushed to rust-lang/rust, and not also the commits in the PRs being merged (which could include subtree pulls).