Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

add recent meeting minutes #31

Merged
merged 1 commit into from
Feb 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions meetings/2021-02-01.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# PEH 2021-02-01 Meeting Agenda

###### tags: `Error Handling` `Minutes`

- Previous Meeting: [2021-01-18 Meeting Minutes](https://github.com/rust-lang/project-error-handling/blob/master/meetings/2021-01-18.md)
- Action Items: https://hackmd.io/@rust-libs/Hyj7kRSld

## Agenda Items

- Review action items from last meeting
- Individual Status Updates
- Review [Project Board](https://github.com/rust-lang/project-error-handling/projects/1) Issues
- https://github.com/rust-lang/rust/pull/80851
- https://github.com/rust-lang/rfcs/pull/3058

# Attendees
- Jane Lusby
- Sean Chen
- Charles Ellis O'Riley Jr.
- oliver
- Jakub Duchniewicz

# Meeting Minutes

- Action items have been moved into a separate [document][action-items-doc].
- [Fixing the error trait][fix-error-trait] seems to have fallen off the radar, perhaps because no one is available to lead it.
- No progress on addressing the error in `rust-sv`.
- No follow up on blog metrics.
- Adding Backtrace to `core` had lots of discussion (i.e. suggestions on implementation approaches), though no implementation progress yet.
- Discussion with the Libs team re. the `Error` trait led to a consensus that the primary role of the trait is for formatting, not downcasting; decided on a guidance for source vs. display.
- Green light on changes to make error formatting more consistent.
- Adding a `panic_error` function similar to `panic_any` (though this might depend on moving the `Error` trait to `core`).
- No progress made on brainstorming topics for the `Error` book
- Setup a Doodle to figure out what time works for those who are interested in attending a brainstorming session.
- [Termination trait][termination-trait] seems to be waiting on generic member access.
- Also needs more design work re. how the final version of `Termination` should look.
- No progress on object provider.
- No follow up on error codes
- Hold off on this until more progress has been made on the `Termination` trait.
- Drop the "better assert messages" issue since someone more knowledgable about it has decided to pick it up.
- [Backtrace frames][backtrace-frames] PR is ready to be merged.
- Progress made on the [2021 panic][2021-panic] implementation, though we aren't explicitly tracking this issue as it's being directly implemented by Mara on the Libs team.
- Proposal for an `Issue Triage` thread dedicated to sorting issues under the group's purview as soon as they're found.
- Figure out how to use `@triagebot` to help stay on top of issues.


[action-items-doc]: https://hackmd.io/@rust-libs/Hyj7kRSld
[fix-error-trait]: https://github.com/rust-lang/rust/issues/53487
[termination-trait]: https://github.com/rust-lang/rust/issues/43301
[backtrace-frames]: https://github.com/rust-lang/rust/pull/81022
[2021-panic]: https://github.com/rust-lang/rust/pull/80851
55 changes: 55 additions & 0 deletions meetings/2021-02-15.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# PEH 2021-02-15 Meeting Agenda

###### tags: `Error Handling` `Minutes`

- Previous Meeting: https://github.com/rust-lang/project-error-handling/blob/master/meetings/2020-02-01.md
- Action Items: https://hackmd.io/@rust-libs/Hyj7kRSld

## Agenda Items

- Review action items from last meeting
- Individual Status Updates
- Any interest in scheduling regular 1 x 1s?
- Review [Project Board](https://github.com/rust-lang/project-error-handling/projects/1) Issues

# Attendees

- Jane Lusby
- Sean Chen
- Charles Ellis O'Riley Jr.
- Jakub Duchniewicz
- DPC
- oliver
- Mara

# Meeting Minutes

- Reviewing open action items:
- "Follow up on the 'Fix the Error trait' issue" is still unassigned: https://github.com/rust-lang/rust/issues/53487
- Main thing that needs to happen is to remove the out of date items about the formatting repr for Backtrace.
- Assigned to DPC
- Regular meeting time was setup to work on the _Rust Error Book_.
- Followed up with Charles explaining `Sized` and `assert2`
- "Plan out changes needed to get `panic_error` added to std/core" assigned to Jane.

- Action Items from the Previous Week
- [x] Hack session to work on the _Rust Error Book_.
- [ ] Follow up on `rust-sv` regression that was introduced with the `impl Error for &E: Error` change.
- [ ] Follow up with infra team to get readership statistics on how many people read the blog post: https://blog.rust-lang.org/inside-rust/2020/11/23/What-the-error-handling-project-group-is-working-on.html.
- Jane made progress on the "Backtrace in core" impl and is hoping to test it and start mass producing ICEs.
- oliver and Jane made good progress on "Dig deeper into the Backtrace in core PR": https://github.com/rust-lang/rust/pull/77384
- Jakub dug through and did some thinking on the "Termination trait polishing" issue: https://github.com/rust-lang/rust/issues/43301#issuecomment-761900006
- May need to wait until the `Try` trait v2 RFC is further along since it may impact the design or impl of the Termination trait.
- Once generic member access is added, we can have the Termination impl alway check the `&dyn Error` type for an `ExitCode` to be used as the exit code when terminating.
- Ideally we'll want to see if we can minimize the dependency between Termination and the `ExitCode` so that Termination "just works" regardless of what extra functionality gets added to `ExitCode` down the line.

- New Action Items Added
- Schedule recurring meeting for book impl / study session [Jane]
- Update API guidelines to add a section on implementing Display vs source: [unassigned]
- Create an issue detailing plan for specializing unwrap / expect for E: Error [Jane]
- Create an issue tracking the desire for an aborting interface for panics [unassigned]
- Create an issue for a non allocating interface for printing a Backtrace [unassigned]
- Create a diagram mapping out the pieces of error handling and how they relate for the book (e.g. Result, panic, Try, Error, etc) [unassigned]

- Recurring _Rust Error Book_ session tentatively scheduled for 11 PST on Thursdays.
- Add https://github.com/rust-lang/rust/pull/80851 and https://github.com/rust-lang/rfcs/pull/3058 to the list of PRs the group is watching.