This repository was archived by the owner on Sep 30, 2020. It is now read-only.
Improve browser detection and install instructions #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "unknown" install box is now stuffed full of text, with the default install instructions. It's not aesthetic, but this is a rare case. |
|
This also fixes an error in the markup where a div was improperly nested in a p. |
|
Looks good to me. @wezm what do you think? |
|
I don't have access to my FreeBSD machine right now to test but the code changes look good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692
Corresponding rustup PR: rust-lang/rustup#936
cc @wezm
r? @steveklabnik