Add links to PGP signatures. Fixes #594. #599
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
While I think this is useful information to expose, I'm not sure the best way to do it. If we were to do this I think we need more than just links that say "PGP". What is a user supposed to do with these files? We at least would need to indicate what their purpose is, how to use them, where the key is, how to validate the key , etc. Adding these links doubles the number of links on the page for something almost nobody is going to use. When we promote rustup.rs to be the main installation method I anticipate the installation options requiring a lot more explanation sadly, so it may make sense to think how to integrate this stuff then. I expect that the install.html page will be the dead-simple installation instructions ala https://www.rustup.rs, and having another page for other installation methods. That page will necessarily have explanation of the differences between install methods, so it could make sense to explain "if you want to validate that your binaries are the same that the Rust project release then ...". |
No description provided.