Skip to content

Follow latest pinning API #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Follow latest pinning API #9

merged 1 commit into from
Sep 24, 2018

Conversation

Kroisse
Copy link
Contributor

@Kroisse Kroisse commented Sep 20, 2018

For rustc 1.30.0-nightly (20dc0c507 2018-09-19) and later.

@cramertj
Copy link
Member

Thanks, this looks great!

@cramertj cramertj merged commit f9bda7a into rust-lang:master Sep 24, 2018
@Arnavion
Copy link

Note for anyone who lands here because futures-preview stopped compiling even with your old pinned nightly:

futures-preview does not pin its dep to exactly 0.1.0-alpha.2, so merging this change and releasing it as 0.1.0-alpha.3 does unfortunately break any user of futures-preview even if they'd pinned their rust toolchain to nightly-2018-09-19 (the last one before the std::future changes that broke pin-utils and futures-preview).

You have to pin the toolchain and your lockfile (after a cargo update -p 'pin-utils' --precise '0.1.0-alpha.2'). Such is nightly life, I suppose :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants