Skip to content

NonNull::dangling uses align_of<T>, not size_of<T> #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2022
Merged

NonNull::dangling uses align_of<T>, not size_of<T> #374

merged 1 commit into from
Jul 18, 2022

Conversation

5225225
Copy link
Contributor

@5225225 5225225 commented Jul 18, 2022

This reverts #371.

Because NonNull::dangling() does not use the size of T, otherwise it would have no way to make a pointer to a ZST.

@Gankra Gankra merged commit 8d1e4dc into rust-lang:master Jul 18, 2022
@Gankra
Copy link
Contributor

Gankra commented Jul 18, 2022

thanks

@5225225 5225225 deleted the align branch August 13, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gankra Gankra Gankra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5225225 @Gankra